[openstreetmap/openstreetmap-website] Migrate `/export/embed.html` from leaflet to maplibre (PR #6804)
Frank Elsinga
notifications at github.com
Tue Mar 24 04:11:33 UTC 2026
@CommanderStorm commented on this pull request.
>
- map.on("moveend", this._update, this);
+ const bbox = (args.get("bbox") || "-180,-90,180,90").split(",");
+ map.fitBounds([[bbox[0], bbox[1]], [bbox[2], bbox[3]]], { animate: false });
Yes, that is what I meant with snapZoom not being entirely implemented.
I can add a quick "hack" if clause on the zoom here and correct it or we handle this via zoomSnap upstream.
The first is something I can do now, the second is something which I still have to implement when I am a little less busy..
I think that users likely won't notice either way..
Being transparent with timelines:
I am willing to do that work upstream but cannot promise that I will get to it before the 30.5. (when I have to submit my thesis).
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6804#discussion_r2978875316
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/6804/review/3996116740 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260323/17ab6506/attachment.htm>
More information about the rails-dev
mailing list