[openstreetmap/openstreetmap-website] Convert more notifications to use Noticed (PR #6933)

Tom Hughes notifications at github.com
Tue Mar 24 19:10:00 UTC 2026


This converts a couple more notifications to use Noticed.

I also renamed the factory added when changeset comment notifications were converted as I realised that is had used a singular name unlike all the others.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/6933

-- Commit Summary --

  * Pluralise test factory name for consistency
  * Deliver note comment notifcations using Noticed
  * Deliver diary comment notifications using Noticed

-- File Changes --

    M app/controllers/api/notes_controller.rb (6)
    M app/controllers/diary_comments_controller.rb (4)
    M app/mailers/user_mailer.rb (4)
    M app/models/diary_comment.rb (4)
    M app/models/diary_entry.rb (4)
    M app/models/note.rb (4)
    M app/models/note_comment.rb (4)
    A app/notifiers/diary_comment_notifier.rb (12)
    A app/notifiers/note_comment_notifier.rb (12)
    R test/factories/changeset_subscriptions.rb (0)
    M test/mailers/previews/user_mailer_preview.rb (4)
    M test/mailers/user_mailer_test.rb (4)
    M test/models/diary_comment_test.rb (15)
    M test/models/diary_entry_test.rb (12)
    M test/models/note_comment_test.rb (15)
    M test/models/note_test.rb (12)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/6933.patch
https://github.com/openstreetmap/openstreetmap-website/pull/6933.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6933
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/6933 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260324/a03746a5/attachment.htm>


More information about the rails-dev mailing list