[openstreetmap/openstreetmap-website] Enable erb-no-instance-variables-in-partials lint rule (PR #6921)
Andy Allan
notifications at github.com
Wed Mar 25 18:21:17 UTC 2026
@gravitystorm commented on this pull request.
> @@ -11,15 +11,15 @@
<div class="col">
<h1><%= @title %></h1>
- <%= render :partial => "navigation" %>
+ <%= render "navigation", :user => @user, :languages => @languages || [] %>
> That is a better solution, yes.
Do you have updated code to push before I merge?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6921?email_source=notifications&email_token=AAK2OLIFQOON7OGMDIXR3CL4SQPR3A5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIMBQHA4DKMZUGUZ2M4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOS6XA4S7OJSXM2LFO5PW433UNFTGSY3BORUW63TTL5RWY2LDNM#discussion_r2990158807
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/6921/review/4008853453 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260325/2782f3f5/attachment-0001.htm>
More information about the rails-dev
mailing list