[openstreetmap/openstreetmap-website] Migrate `/export/embed.html` from leaflet to maplibre (PR #6804)
Marwin Hochfelsner
notifications at github.com
Wed Mar 25 19:21:37 UTC 2026
@hlfan commented on this pull request.
> + // check if attribution string is different to minimize DOM changes
+ if (attribHTML === this._attribHTML) return;
+
+ this._innerContainer.innerHTML = attribHTML;
+ this._attribHTML = attribHTML;
+ this._updateCompact();
+
+ // Update report link href after initial render
+ if (this._includeReportLink) {
+ this._updateReportLink();
+ }
+ }
+
+ _buildCreditHtml(credit) {
+ const children = {};
+ if (credit.children) {
Is this condition actually guarding against anything the loop cares about?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6804?email_source=notifications&email_token=AAK2OLKVHUASRFB7ZAPVSVD4SQWUDA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIMBQHEZDKMJSGA3KM4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOS6XA4S7OJSXM2LFO5PW433UNFTGSY3BORUW63TTL5RWY2LDNM#pullrequestreview-4009251206
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/6804/review/4009251206 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260325/ef858a96/attachment.htm>
More information about the rails-dev
mailing list