[openstreetmap/openstreetmap-website] Notification conversions: direct message and new follower (PR #6944)

Pablo Brasero notifications at github.com
Thu Mar 26 17:50:59 UTC 2026


Following https://github.com/openstreetmap/openstreetmap-website/pull/6837, and sibling to https://github.com/openstreetmap/openstreetmap-website/pull/6933 and https://github.com/openstreetmap/openstreetmap-website/pull/6939, here are a couple more of notifiers. I have avoided the names `MessageNotificatioNotifier` and `FollowNotificationNotifier` and instead opted for something hopefully more descriptive. I would rename the actual mailer methods too, but then we'd have to change the i18n keys, etc, and that's too much, I think.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/6944?email_source=notifications&email_token=AAK2OLKDZJLDI2ASMUC2LH34SVUYHA5CNFSNUABEM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UF4ZTINJSHA4TGMRTHCTHEZLBONXW5KTTOVRHGY3SNFRGKZFFMV3GK3TUVVYHEX3POBSW4X3DNRUWG2Y

-- Commit Summary --

  * Use Noticed to deliver a "new follower" notification
  * Use Noticed to deliver notifications of direct messages

-- File Changes --

    M app/controllers/api/messages_controller.rb (2)
    M app/controllers/follows_controller.rb (2)
    M app/controllers/messages_controller.rb (2)
    M app/mailers/user_mailer.rb (10)
    A app/notifiers/direct_message_notifier.rb (12)
    A app/notifiers/new_follower_notifier.rb (12)
    M test/mailers/previews/user_mailer_preview.rb (4)
    M test/mailers/user_mailer_test.rb (9)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/6944.patch?email_source=notifications&email_token=AAK2OLO2LTRW7NP6N5UU2SL4SVUYHA5CNFSNUABEM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UF4ZTINJSHA4TGMRTHCTHEZLBONXW5KTTOVRHGY3SNFRGKZFFMV3GK3TUVZYHEX3QMF2GG2C7MNWGSY3Lhttps://github.com/openstreetmap/openstreetmap-website/pull/6944.diff?email_source=notifications&email_token=AAK2OLL4X6FZC7AE5ZSHLLT4SVUYHA5CNFSNUABEM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UF4ZTINJSHA4TGMRTHCTHEZLBONXW5KTTOVRHGY3SNFRGKZFFMV3GK3TUVVYHEX3ENFTGMX3DNRUWG2Y
-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6944
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/6944 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260326/217d05d2/attachment-0001.htm>


More information about the rails-dev mailing list