[openstreetmap/openstreetmap-website] Notification conversions: direct message and new follower (PR #6944)

[Pablo Brasero]

@pablobm commented on this pull request.



> @@ -85,7 +85,7 @@ def gpx_failure
   end
 
   def message_notification
-    message = params.fetch(:message)
+    message, recipient = params.fetch_values(:record, :recipient)
 
     with_recipient_locale message.recipient do
       @to_user = message.recipient.display_name

Yeah, I dithered a bit here, wondering if there should be a distinction between the real recipient (as passed in the arguments) and the stated recipient (as recorded in the message). Something like: what if in the future we have a feature allowing admins to see what other messages would look like, or something like that... but that's adding complication, so I'll do as you say which is much simpler.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6944?email_source=notifications&email_token=AAK2OLPZ33IEEZYBN5B3ND34SYVN7A5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIMBRHEZTSOJRHE3KM4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOS6XA4S7OJSXM2LFO5PW433UNFTGSY3BORUW63TTL5RWY2LDNM#discussion_r2999455745
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/6944/review/4019399196 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260327/bcb5ae38/attachment-0001.htm>