[openstreetmap/openstreetmap-website] Migrate `/export/embed.html` from leaflet to maplibre (PR #6804)

[Frank Elsinga]

@CommanderStorm commented on this pull request.



> +    // check if attribution string is different to minimize DOM changes
+    if (attribHTML === this._attribHTML) return;
+
+    this._innerContainer.innerHTML = attribHTML;
+    this._attribHTML = attribHTML;
+    this._updateCompact();
+
+    // Update report link href after initial render
+    if (this._includeReportLink) {
+      this._updateReportLink();
+    }
+  }
+
+  _buildCreditHtml(credit) {
+    const children = {};
+    if (credit.children) {

Ah, did not know that for..in does behave differently to for..of

I would have expected that if one errors the other also should.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6804?email_source=notifications&email_token=AAK2OLJGGN4K4CXRIK4A7NT4SZU7PA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIMBSGA3TENBWGUYKM4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOS6XA4S7OJSXM2LFO5PW433UNFTGSY3BORUW63TTL5RWY2LDNM#discussion_r3000616918
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/6804/review/4020724650 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260327/514eb0be/attachment.htm>