[openstreetmap/openstreetmap-website] Notification conversions: direct message and new follower (PR #6944)
Tom Hughes
notifications at github.com
Sat Mar 28 11:22:06 UTC 2026
@tomhughes commented on this pull request.
> @@ -85,7 +85,7 @@ def gpx_failure
end
def message_notification
- message = params.fetch(:message)
+ message, recipient = params.fetch_values(:record, :recipient)
with_recipient_locale message.recipient do
@to_user = message.recipient.display_name
My reasoning was mostly that it's used to address the recipient, as "Hi <name>" at the top of the email so even if we were notifying somebody else it would still be right to use the current recipients name.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6944?email_source=notifications&email_token=AAK2OLKZR7CRVBTKY67ODBD4S6YV5A5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIMBSGU2DSNJVGI3KM4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOS6XA4S7OJSXM2LFO5PW433UNFTGSY3BORUW63TTL5RWY2LDNM#discussion_r3004721945
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/6944/review/4025495526 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260328/17ac07fa/attachment.htm>
More information about the rails-dev
mailing list