[openstreetmap/openstreetmap-website] Fix login tab order for "Lost your password?" link (PR #6947)

Marwin Hochfelsner notifications at github.com
Sun Mar 29 18:35:11 UTC 2026


@hlfan commented on this pull request.



>      <%= f.primary t(".login_button") %>
-  </div>

I don't really love how the link now floats around here.
Also, we should drop the `:skip_label` option if we can.
What do you think about this way?

```suggestion
  <%= f.text_field :username, :label => t(".email or username"), :autofocus => true, :value => params[:username] %>
  <%= f.password_field :password, :label => t(".password"), :autocomplete => "on", :value => "" %>

  <div class="d-flex flex-wrap column-gap-3 justify-content-between align-items-baseline mb-2">
    <%= f.form_group do %>
      <%= f.check_box :remember_me, { :label => t(".remember"), :checked => (params[:remember_me] == "true") }, "yes" %>
      <%= f.primary t(".login_button") %>
    <% end %>
    <small><%= link_to(t(".lost password link"), user_forgot_password_path) %></small>
  </div>
```

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6947?email_source=notifications&email_token=AAK2OLLYJ5SIIE6YISKLQET4TF3G7A5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIMBSG4YTCNBZHA22M4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOS6XA4S7OJSXM2LFO5PW433UNFTGSY3BORUW63TTL5RWY2LDNM#pullrequestreview-4027114985
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/6947/review/4027114985 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260329/61ed1a98/attachment.htm>


More information about the rails-dev mailing list