[openstreetmap/openstreetmap-website] Fix login tab order for "Lost your password?" link (PR #6947)

[Marwin Hochfelsner]

@hlfan commented on this pull request.



> +<div class="position-relative mb-2">
+  <%= f.check_box :remember_me, { :label => t(".remember"), :checked => (params[:remember_me] == "true") }, "yes" %>
 
-  <%= f.form_group do %>
-    <%= f.check_box :remember_me, { :label => t(".remember"), :checked => (params[:remember_me] == "true") }, "yes" %>
-  <% end %>
+  <small class="d-none d-sm-block position-absolute end-0 top-0">
+    <%= link_to(t(".lost password link"), user_forgot_password_path) %>
+  </small>
+</div>
+<div class="mb-3">
+  <%= f.primary t(".login_button") %>
+</div>
 
-  <div class="mb-3">
-    <%= f.primary t(".login_button") %>
-  </div>
+<div class="d-sm-none">
+  <small>
+    <%= link_to(t(".lost password link"), user_forgot_password_path) %>
+  </small>
+</div>

I don't think swapping out the link is the right thing to do when already concerned about tab order a11y, when it can just wrap when necessary.

```suggestion
  <div class="d-flex flex-wrap column-gap-3 justify-content-between align-items-baseline mb-2">
    <%= f.form_group do %>
      <%= f.check_box :remember_me, { :label => t(".remember"), :checked => (params[:remember_me] == "true") }, "yes" %>
      <%= f.primary t(".login_button") %>
    <% end %>
    <small><%= link_to(t(".lost password link"), user_forgot_password_path) %></small>
  </div>
```

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6947?email_source=notifications&email_token=AAK2OLIFF3AMS6HFDOVGFV34TGCPNA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIMBSG4YTOOBVHEY2M4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOS6XA4S7OJSXM2LFO5PW433UNFTGSY3BORUW63TTL5RWY2LDNM#pullrequestreview-4027178591
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/6947/review/4027178591 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260329/5ee603b9/attachment.htm>