[openstreetmap/openstreetmap-website] Fixed notifications reload error (PR #7359)

[Mohd Farhan Akhtar]

imfarhan0105-bits left a comment (openstreetmap/openstreetmap-website#7359)

Yeah, I agree with this. Thinking about it again, the notification should really represent something that happened, rather than the current state of the relationship. If someone followed me and I received a notification for it, that event is still valid even if they later decide to unfollow me. Removing it afterwards would effectively erase that history, and I agree that being able to click through to their profile still makes the notification useful.

I also hadn't considered the email notification angle initially. If the email tells me that someone followed me, I'd expect the corresponding site notification to remain as well.

And you're right about the existing orphaned notifications. My current approach only handles them at render time, while the cleanup would only apply going forward. So it doesn't really address the existing cases that led to this issue in the first place.

I'll rethink the approach properly. Thanks for pointing this out.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/7359#issuecomment-5529471739
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/7359/c5529471739 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260903/f9b3cce3/attachment-0001.htm>