[openstreetmap/openstreetmap-website] Ignore invalid object IDs in various redirects (PR #7372)
Kai Michael Poppe
notifications at github.com
Thu Sep 10 05:15:45 UTC 2026
kmpoppe left a comment (openstreetmap/openstreetmap-website#7372)
I'm sure I just haven't understood Rails correctly (at all), so sorry if that's a stupid question:
In app/controllers/site_controller.rb
- `def permalink` has checks for node/way/relation/changeset, while
- `def redirect_browse_params` has them for node/way/relation/note
- (same as `def test_index_redirect`in test/controllers/site_controller_test.rb)
are the "missing" note in permalink and changeset in redirect_browse_params just never going to occur?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/7372#issuecomment-5613550294
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/7372/c5613550294 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260909/a9b75bde/attachment-0001.htm>
More information about the rails-dev
mailing list