[openstreetmap/openstreetmap-website] Send request parameter to any configured sentry endpoint (PR #7398)
Pablo Brasero
notifications at github.com
Mon Sep 21 14:15:11 UTC 2026
@pablobm commented on this pull request.
Seems to work well 👍
Before:
<img width="1225" height="288" alt="Excerpt of error report on GlitchTip. Doesn't show the query string" src="https://github.com/user-attachments/assets/cabb6bd7-011f-46be-af15-faccdc4f91df" />
After:
<img width="1225" height="288" alt="Excerpt of same section. This time it shows the query string" src="https://github.com/user-attachments/assets/9bd8d7e1-76bd-4e35-86d4-85f61d1a73b6" />
> @@ -5,5 +5,7 @@
config.dsn = Settings.sentry_dsn
config.traces_sample_rate = Settings.sentry_traces_sample_rate if Settings.key?(:sentry_traces_sample_rate)
config.breadcrumbs_logger = [:active_support_logger, :http_logger]
+ config.data_collection.url_query_params.mode = :deny_list
+ config.data_collection.url_query_params.terms = %w[password pass_crypt pass_crypt_confirmation]
I have checked locally and looks like we can use the existing declaration:
```suggestion
config.data_collection.url_query_params.terms = Rails.application.config.filter_parameters
```
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/7398#pullrequestreview-5267648641
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/7398/review/5267648641 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260921/ffd6465c/attachment-0001.htm>
More information about the rails-dev
mailing list