<p><b>@gravitystorm</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1367">test/controllers/old_node_controller_test.rb</a>:</p>
<pre style='color:#555'>> @@ -90,6 +90,9 @@ def test_version
     xml_node = xml_doc.find("//osm/node").first
     nodeid = current_nodes(:node_with_versions).id
 
+    # Ensure that the current tags are propogated to the history too
+    propogate_tags(current_nodes(:node_with_versions), nodes(:node_with_versions_v4))
</pre>
<p>I've fixed the spelling, and added some tags to be propagated. The confusion is that I refactored the old_node into factories first, and then the tags were inconsistent, but after refactoring the current_nodes into factories, the tags were consistently missing!</p>

<p>Of course, it's a sign of dodgy tests that one can miss out the tag creation without causing test failures, but I want to avoid whole-sale rewriting of all the tests and just focus on swapping fixtures for factories.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1367">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLaKQhnMHT5QE-2Ll99asbyBtbYRjks5q_DZsgaJpZM4KtvV_">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABWnLfW4PUXSt_gY-l8kmmCzGsaJiupPks5q_DZsgaJpZM4KtvV_.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/openstreetmap/openstreetmap-website/pull/1367"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"PERSON","message":"@gravitystorm commented on #1367"}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/openstreetmap-website/pull/1367"}}}</script>