<blockquote>
<p>So I'm interested in why you think it's a worse solution?</p>
</blockquote>
<p>Mainly just the slowdown from having to write files to disk (when they already exist elsewhere on the disk anyway), which is a big slowdown compared to stubbing things, especially when the models only need to <em>read</em> from disk anyway. Then if we're writing stuff to disk during a test, we need to make sure we clean everything up again. With the stubbing, when the tests finish (or are interrupted) there's nothing permanent.</p>
<p>So that's why I prefer stubbing to shifting things around on disk. But if you'd prefer to do the disk approach I can do that.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1347#issuecomment-267903510">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLS-nEt1NNGEAIyToDr13jMl3pGe_ks5rJjmUgaJpZM4KkH9o">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABWnLZeRDphlCa6ACtgrsTHIeJxinoJYks5rJjmUgaJpZM4KkH9o.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/openstreetmap/openstreetmap-website/pull/1347#issuecomment-267903510"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"PERSON","message":"@gravitystorm in #1347: \u003e So I'm interested in why you think it's a worse solution?\r\n\r\nMainly just the slowdown from having to write files to disk (when they already exist elsewhere on the disk anyway), which is a big slowdown compared to stubbing things, especially when the models only need to *read* from disk anyway. Then if we're writing stuff to disk during a test, we need to make sure we clean everything up again. With the stubbing, when the tests finish (or are interrupted) there's nothing permanent.\r\n\r\nSo that's why I prefer stubbing to shifting things around on disk. But if you'd prefer to do the disk approach I can do that."}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/openstreetmap-website/pull/1347#issuecomment-267903510"}}}</script>