<p><b>@krubokrubo</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2072#discussion_r236933214">app/helpers/format_links_helper.rb</a>:</p>
<pre style='color:#555'>> @@ -0,0 +1,138 @@
+require "cgi"
+
+module FormatLinksHelper
</pre>
<p>Sounds good, this is renamed now.</p>
<p>I'm fairly new to Ruby and rubocop, so I don't yet have an opinion about the rubocop rules, I was just trying to resolve the cascade of offenses. (First I got ModuleLength, then when I split the module it led to AssignmentInCondition, although I realize I made this unclear by committing the fixes in reverse order.)</p>
<p>If you're not concerned about those offenses, I'm happy to leave them as they were.  In that case, we could just look at commit <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/openstreetmap/openstreetmap-website/commit/5ba64efd7c426b99b4bcbad7a9b841daf13eba06/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/commit/5ba64efd7c426b99b4bcbad7a9b841daf13eba06"><tt>5ba64ef</tt></a> for this feature.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2072#discussion_r236933214">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLQcDTdH19LEYg3leubxh0LONPvhbks5uzgipgaJpZM4Y0ZKk">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABWnLbqN8AkshMwYt6O8u8Mf0su3XBLmks5uzgipgaJpZM4Y0ZKk.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"PERSON","message":"@krubokrubo commented on #2072"}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/openstreetmap-website/pull/2072#discussion_r236933214"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/2072#discussion_r236933214",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/2072#discussion_r236933214",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "@krubokrubo commented on 2072",
"sections": [
{
"text": "",
"activityTitle": "**krubokrubo**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@krubokrubo",
"facts": [

]
}
],
"potentialAction": [
{
"targets": [
{
"os": "default",
"uri": "https://github.com/openstreetmap/openstreetmap-website/pull/2072#discussion_r236933214"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 416387748\n}"
}
],
"themeColor": "26292E"
}
]</script>