<blockquote>
<p>I think there's need for .empty? guards when using</p>
</blockquote>
<p>Sorry, that should have read 'I think there's <strong>no</strong> need for' the guards.</p>
<blockquote>
<p>The reason why this is outside of <code>xml.node(attrs) do |nd|</code> is that it fails horribly otherwise - either producing invalid XML or simply crashing, I don't recall at the moment.</p>
</blockquote>
<p>Oh, then perhaps there is. That's a pity since I would have thought the <code>each</code> simply doesn't do anything when there's no tags.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2223?email_source=notifications&email_token=AAK2OLLHZLKLIVX3VZTSPXTP4RVNNA5CNFSM4HLMFYO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYWHZ7Q#issuecomment-506232062">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLLKASWFMSER3PVFKU3P4RVNNANCNFSM4HLMFYOQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/AAK2OLK2FZ7YX5S47MVCZFTP4RVNNA5CNFSM4HLMFYO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYWHZ7Q.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/2223?email_source=notifications\u0026email_token=AAK2OLLHZLKLIVX3VZTSPXTP4RVNNA5CNFSM4HLMFYO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYWHZ7Q#issuecomment-506232062",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/2223?email_source=notifications\u0026email_token=AAK2OLLHZLKLIVX3VZTSPXTP4RVNNA5CNFSM4HLMFYO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYWHZ7Q#issuecomment-506232062",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>