<p><b>@tomhughes</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2452#discussion_r359405942">app/assets/stylesheets/_bootstrap-custom.scss</a>:</p>
<pre style='color:#555'>> @@ -0,0 +1,44 @@
+/*!
+ * Bootstrap v4.3.1 (https://getbootstrap.com/)
+ * Copyright 2011-2019 The Bootstrap Authors
+ * Copyright 2011-2019 Twitter, Inc.
+ * Licensed under MIT (https://github.com/twbs/bootstrap/blob/master/LICENSE)
+ */
</pre>
<p>If this is upstream code shouldn't it be in <code>vendor</code> instead of <code>app</code>? I guess in truth it's a kind of halfway house in that this is a template that you're expected to edit?</p>
<p>Is this expected to go away once we are able to just enable the whole thing?</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2452#discussion_r359406411">app/assets/stylesheets/common.scss</a>:</p>
<pre style='color:#555'>> @@ -1,4 +1,5 @@
 @import "parameters";
+@import "bootstrap-custom";
</pre>
<p>How does this find the other file when the file starts with an underscore? Is there some rule where the scss preprocessor searches for files with the underscore?</p>
<p>What's the logic behind preferring a CSS level <code>@import</code> over a sprockets level require? Then again we already seem to have a mix of both and I'm not sure how the split was decided...</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2452#discussion_r359409369">app/assets/stylesheets/screen-ltr.css</a>:</p>
<pre style='color:#555'>> @@ -1,5 +1,5 @@
 /*
  *= require ltr/common
- *= require bootstrap
+ *= require bootstrap-tooltips
</pre>
<p>Presumably a fairly short term goal will be to replace the existing vendored tooltip and dropdown support with something based on the bootstrap gem instead? I assume you've tested that there isn't any issue with mixing the two in the short term...</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2452?email_source=notifications&email_token=AAK2OLNCD5NMNQMG3BDL5TLQZI6Y3A5CNFSM4JVK26ZKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCPUTMKY#pullrequestreview-334050859">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLIX3WM73DENHFV22ATQZI6Y3ANCNFSM4JVK26ZA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AAK2OLK7J7EVRRBOQE4OOM3QZI6Y3A5CNFSM4JVK26ZKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCPUTMKY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/2452?email_source=notifications\u0026email_token=AAK2OLNCD5NMNQMG3BDL5TLQZI6Y3A5CNFSM4JVK26ZKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCPUTMKY#pullrequestreview-334050859",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/2452?email_source=notifications\u0026email_token=AAK2OLNCD5NMNQMG3BDL5TLQZI6Y3A5CNFSM4JVK26ZKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCPUTMKY#pullrequestreview-334050859",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>