<p></p>
<p><b>@tomhughes</b> commented on this pull request.</p>

<p>Looks like a good start to me...</p>
<p>The initializers, especially the bootstrap one, are a little disturbing ;-)</p><hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2655#discussion_r438708787">lib/templates/erb/scaffold/_form.html.erb</a>:</p>
<pre style='color:#555'>> @@ -0,0 +1,15 @@
+<%# frozen_string_literal: true %>
</pre>
<p>Is this actually used by anything?</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2655#discussion_r438714129">config/locales/en.yml</a>:</p>
<pre style='color:#555'>> @@ -116,6 +117,20 @@ en:
       # html: '<abbr title="required">*</abbr>'
     error_notification:
       default_message: "Please review the problems below:"
+    hints:
+      trace:
+        tagstring: comma delimited
+    labels:
+      trace:
+        gpx_file: Upload GPX File
+        visibility: Visibility
+    options:
+      trace:
+        visibility:
+          private: Private (only shared as anonymous, unordered points)
+          public: Public (shown in trace list and as anonymous, unordered points)
+          trackable: Trackable (only shared as anonymous, ordered points with timestamps)
+          identifiable: Identifiable (shown in trace list and as identifiable, ordered points with timestamps)
</pre>
<p>With these descriptions moved here do we still need the old ones?</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2655#discussion_r438715310">app/views/traces/edit.html.erb</a>:</p>
<pre style='color:#555'>> -    </div>
-    <div class='standard-form-row'>
-      <label class='standard-label'><%= t ".tags" %></label>
-      <%= f.text_field :tagstring %> (<%= t ".tags_help" %>)
-    </div>
-    <div class='standard-form-row'>
-      <label class='standard-label'><%= t ".visibility" %></label>
-      <%= f.select :visibility, [[t("traces.visibility.private"), "private"], [t("traces.visibility.public"), "public"], [t("traces.visibility.trackable"), "trackable"], [t("traces.visibility.identifiable"), "identifiable"]] %> (<a href="<%= t ".visibility_help_url" %>"><%= t ".visibility_help" %></a>)
-    </div>
-  </fieldset>
-
-</div>
-
-<%= f.submit %>
-
+<%= simple_form_for @trace do |f| %>
</pre>
<p>This seems to have lost all the extra information that was displayed before the editable fields - is that a deliberate decision?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2655#pullrequestreview-428808993">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLOXHXHEMIU74VHSQ4TRWC5JVANCNFSM4N3JAG5A">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AAK2OLOQC7HE4Z3OYAR6BATRWC5JVA5CNFSM4N3JAG5KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGODGHRWII.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/2655#pullrequestreview-428808993",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/2655#pullrequestreview-428808993",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>