<p></p>
<p><b>@gravitystorm</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2409#discussion_r570115583">docker/postgres/Dockerfile</a>:</p>
<pre style='color:#555'>> @@ -0,0 +1,7 @@
+FROM postgres:11
+
+# Add db init script to install OSM-specific Postgres functions/extensions.
+ADD docker/postgres/openstreetmap-postgres-init.sh /docker-entrypoint-initdb.d/
+
+# Custom database functions are in a SQL file.
+ADD db/functions/functions.sql /usr/local/sbin/osm-db-functions.sql
</pre>
<p>Unfortunately yes, we still need it. The <code>tile_for_point</code> SQL function is not needed for day-to-day operations (and so not required for the tests), since we calculate the tile using the QuadTile gem before storing it, and we again use the QuadTile gem to generate the (giant) select queries.</p>
<p>But there's also the database migrations where the columns were added, and those migrations backfill the tile columns using the SQL function.</p>
<p>I have much else to say about ancient migrations, but for now, we can't just drop the SQL function entirely.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2409#discussion_r570115583">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLLJ5ABZ5T25QASI5KDS5JZYFANCNFSM4JDURRXA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AAK2OLJBDC7GAFROWSHZ3UDS5JZYFA5CNFSM4JDURRXKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOELB24WY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/2409#discussion_r570115583",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/2409#discussion_r570115583",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>