[Routing] gosmore bugfix

[David Dean]

Klaus,

To ensure they get noticed, Gosmore bugs should be submitted to
trac.openstreetmap.org under the 'gosmore' component. This would allow one
of the gosmore devs (mostly Nic Roets and I) to have a good look at it.

You also have not given any indication what the bug is here, and what this
fix is supposed to do to fix it. Even in fairly obvious patches like this
one, outlining what is the problem and how it is being fixed is always a
good idea.

In particular, I would like to know if this was causing any visible bugs in
the program, or if you have just noticed this while reviewing the code.

As this appears to be a pretty obvious fix, I will merge your patch and
submit it back up to the svn within a few days.

Thankyou for your help in improving gosmore,

- David


Klaus Rechert-2 wrote:
> 
> Hi,
> 
> this is not quite the right list for technical issues, but I haven't 
> found a dedicated gosmore list. bugfix below.
> 
> cheers
>     Klaus
> 
> 
> 
> Index: libgosm.cpp
> ===================================================================
> --- libgosm.cpp    (Revision 15955)
> +++ libgosm.cpp    (Arbeitskopie)
> @@ -480,7 +480,7 @@
>          malloc ((sizeof (*route) + sizeof (*routeHeap)) * dhashSize))) {
>        dhashSize = dhashSize / 4 * 3;
>      }
> -    memset (route, 0, sizeof (dhashSize) * dhashSize);
> +    memset (route, 0, (sizeof (*route) + sizeof (*routeHeap)) *
> dhashSize);
>      #endif
>      routeHeapSize = 1; /* Leave position 0 open to simplify the math */
>      routeHeap = (routeNodeType**) (route + dhashSize) - 1;
> 
> 
> _______________________________________________
> Routing mailing list
> Routing at openstreetmap.org
> http://lists.openstreetmap.org/listinfo/routing
> 
> 

-- 
View this message in context: http://www.nabble.com/gosmore-bugfix-tp24144459p24146997.html
Sent from the OpenStreetMap - Routing mailing list archive at Nabble.com.