[Taginfo-dev] [taginfo/taginfo] 22cbf2: Disable filter if unknown filter is used

Jochen Topf noreply at github.com
Mon Jul 11 16:00:15 UTC 2022


  Branch: refs/tags/osmorg-taginfo-live
  Home:   https://github.com/taginfo/taginfo
  Commit: 22cbf2e4b583233d52ef0d8efeb233e1fa417977
      https://github.com/taginfo/taginfo/commit/22cbf2e4b583233d52ef0d8efeb233e1fa417977
  Author: Jochen Topf <jochen at topf.org>
  Date:   2022-07-11 (Mon, 11 Jul 2022)

  Changed paths:
    M web/lib/utils.rb

  Log Message:
  -----------
  Disable filter if unknown filter is used

Instead of raising an error. In normal operation this won't happen
anyway and we'll avoid an internal server error or some error like that
with the change.


  Commit: 4a48809823cfd03573315c3b386d111902262c7c
      https://github.com/taginfo/taginfo/commit/4a48809823cfd03573315c3b386d111902262c7c
  Author: Jochen Topf <jochen at topf.org>
  Date:   2022-07-11 (Mon, 11 Jul 2022)

  Changed paths:
    M web/views/key.erb
    M web/views/project.erb
    M web/views/relation.erb
    M web/views/search.erb
    M web/views/search_tags.erb
    M web/views/tag.erb
    M web/viewsjs/project.js.erb
    M web/viewsjs/relation.js.erb
    M web/viewsjs/search.js.erb
    M web/viewsjs/tag.js.erb

  Log Message:
  -----------
  Reduce the amount of inline javascript generated on dynamic pages

It makes the code simpler and there is less of an attack surface for
XSS. (Not that XSS is a big issues because the whole site is read-only
and there is way to steal any data or so.)


Compare: https://github.com/taginfo/taginfo/compare/39de5998cffc...4a48809823cf



More information about the Taginfo-dev mailing list