[Talk-GB] Beta release: Address mapping tool

[Rob Nickerson]

Hi Tom, all,

On Sat, 12 Feb 2022 at 10:31, Tom Crocker <tomcrockermail at gmail.com> wrote:

> Hi Rob, Russ and Pieter
>
> Well done for getting this far. I can see a lot work has gone into this
> tool. Here's a few initial observations and suggestions from me.
>

Thanks Tom. Lots of hard work has indeed gone into this but all in the aim
of making OpenStreetMap better :-). And I'm really happy with the progress
made too.


>
> Bugs:
> The check against existing addresses seems to be failing in an
> inconsistent way... On both Firefox for Android and Windows, if I zoom in
> and pan around (not very far) I end up with the OSM address point and the
> importable point for some locations persisting. The order seems arbitrary -
> if the OSM address point could be forced to be on top it would be less
> problematic. If I reload the importable points disappear. I can pan further
> and find points that still disappear, so it doesn't seem to have completely
> frozen. I've put some screenshots here:
> https://drive.google.com/drive/folders/1w5M3sq2LvqgNgCADKo_j0dQdJBqYmb0Y?usp=sharing
>
>
I tested this and can confirm. Not sure what the cause is. Perhaps it only
re-runs the matching code when you pan further away.


> In a few cases with addresses around Pierremont Crescent
> https://www.openstreetmap.org/way/62267637 it wasn't listed as one of the
> streets to use even though it is the closest highway, yet in others for the
> same way it was listed (screenshot in the same folder as above).
>
>
I'm not sure how the closeness to street algorithm works. Perhaps it just
works on a centre point for the way and hence occasional odd cases like
this.


> Workflow improvements:
> When you import an address point, it should immediately launch the "Review
> and update the address" dialogue. With the current process it is a bit
> confusing as you say you're going to add an address but then you don't type
> anything in. You're left with a very similar icon to the one you originally
> clicked to click again to add the details. Some people may think they've
> done it automagically by finishing the "add address" process.
>

It should immediately launch the questions dialogue and was doing that when
I last tested it. But I now have the same problem as you. I am CC'ing
Pieter to see if he has any free time to look into this. Hopefully it is
just a recent code change that has resulted in this and is easy to fix.
Let's hope that is the case :-)


>
> <snip>
>

I'll come back to tag points in a bit if that's ok.


>
> Hope that helps
>
>
> Tom
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/talk-gb/attachments/20220212/425db2d8/attachment.htm>