[Talk-us] [bot] Proposal to fix issue with duplicated inner polygons in the United States

Thu Feb 17 14:28:52 UTC 2022

Hello,

We appreciate your engagement and great insights!

First, let me get back to Minh's suggestion regarding boundary relations.

We performed more data analysis on that matter. We looked at all the relations logged by Osmose and checked how many of them have a boundary=* tag. We found 50 such cases (out of almost 20,000):

  *   3 cases where boundary=national_park,
  *   47 cases where boundary=protected_area.

Both types of cases are examples of natural multipolygons, so it seems like the issue mentioned by you is not present. These cases will be handled by our bot using the approach described on the wiki page.

> Having experience with editing some of the Lousiana coastal areas, it's several failed, incomplete, and possibly overlapping NHD imports with a mess of invalid multi-polygons, unclosed features, and any other error you can think of. I would recommend against turning the bot loose on that geometry until simpler test cases are attempted.

Our proposed bot handles cases logged by Osmose, and these should have closed geometry by default. Nevertheless, the verifiers to be executed in this mechanical update (mentioned in the wiki documentation in this section<https://wiki.openstreetmap.org/wiki/Automated_edits/TTmechanicalupdates/Fix_issue_with_duplicated_inner_polygons_in_United_States#Algorithm>) include a check to see whether "all ways are closed". That way we will surely handle issues without corrupting any data.

> Will these be updated after every hurricane comes through and changes the coastline?

For now, we treat this as an action to fix the current map state, solving the violations logged by Osmose (Osmose Rule 1170 Class 1<http://osmose.openstreetmap.fr/en/issues/open?item=1170&source=&class=1&username=&bbox=>). In case similar issues appear in the future–the bot code is created, published, and ready to be used by anyone at any time.

Does this answer your concerns?

If you have any more questions or remarks, do not hesitate to reach out!

Kind regards,
Marjan

From: Eric Patrick <txemt1 at gmail.com>
Sent: donderdag 17 februari 2022 2:17
To: Eric Ladner <eric.ladner at gmail.com>
Cc: TomTom OSM <OSM at tomtom.com>; Minh Nguyen <minh at nguyen.cincinnati.oh.us>; talk-us at openstreetmap.org
Subject: Re: [Talk-us] [bot] Proposal to fix issue with duplicated inner polygons in the United States

You don't often get email from txemt1 at gmail.com<mailto:txemt1 at gmail.com>. Learn why this is important<http://aka.ms/LearnAboutSenderIdentification>
Will these be updated after every hurricane comes through and changes the coastline?

On Tue, Feb 15, 2022 at 2:24 PM Eric Ladner <eric.ladner at gmail.com<mailto:eric.ladner at gmail.com>> wrote:
Having experience with editing some of the Lousiana coastal areas, it's several failed, incomplete, and possibly overlapping NHD imports with a mess of invalid multi-polygons, unclosed features, and any other error you can think of.

I would recommend against turning the bot loose on that geometry until simpler test cases are attempted.

On Tue, Feb 15, 2022 at 5:20 AM TomTom OSM <OSM at tomtom.com<mailto:OSM at tomtom.com>> wrote:
Hi Minh,

Thank you for your kind words, and valuable feedback!

I passed your suggestions to my team. They will take a closer look at them, and I'll get back with more details in a while.

Kind regards,
Marjan

-----Original Message-----
From: Minh Nguyen <minh at nguyen.cincinnati.oh.us<mailto:minh at nguyen.cincinnati.oh.us>>
Sent: Friday, February 11, 2022 6:58 PM
To: talk-us at openstreetmap.org<mailto:talk-us at openstreetmap.org>
Subject: Re: [Talk-us] [bot] Proposal to fix issue with duplicated inner polygons in the United States

[You don't often get email from minh at nguyen.cincinnati.oh.us<mailto:minh at nguyen.cincinnati.oh.us>. Learn why this is important at http://aka.ms/LearnAboutSenderIdentification.]

Vào lúc 04:25 2022-02-08, TomTom OSM đã viết:
> We propose to do a test run by updating invalid polygons in the
> Louisiana state, where 5,541 cases are logged by the Osmose rule. Per
> the Automated Edits code of conduct, we will wait for your feedback
> before we begin.

Hi Marjan, at a glance, it looks like many of the issues involve multipolygons imported from NHD, since Louisiana has a very complex coastline and system of bayous. [1][2] I think many of us would welcome help cleaning up old NHD imports, particularly regarding topology issues.

If you later move on to other states, you may need to pay additional attention to occurrences of this warning that don't only involve natural multipolygons. For example, it's possible that a natural feature might be coincident to an enclave of a boundary relation. I'm unsure if mappers would prefer the boundary relation to be conflated with the natural feature or kept separate from it.

[1] https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwiki.openstreetmap.org%2Fwiki%2FNational_Hydrography_Dataset&data=04%7C01%7Cosm%40tomtom.com%7Ca2065442e7e14a5f7f7408d9ed886316%7C374f80267b544a3ab87d328fa26ec10d%7C0%7C0%7C637801992953769114%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=DdeDNtg2FTWBWHq5B3nViP%2BQi7M8OqEb5kylsBUBcEg%3D&reserved=0<https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwiki.openstreetmap.org%2Fwiki%2FNational_Hydrography_Dataset&data=04%7C01%7COSM%40tomtom.com%7C312db3a6e387408918b908d9f1b34499%7C374f80267b544a3ab87d328fa26ec10d%7C0%7C0%7C637806575286727370%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=oIxHadm00ZEiIpOgTXCbpcI%2B8X%2Bm2dO9k1zZ30EJDKc%3D&reserved=0>
[2]
https://eur02.safelinks.protection.outlook.com/?url=http%3A%2F%2Fosmose.openstreetmap.fr%2Fen%2Fissues%2Fopen%3Fsource%3D10139%26item%3D1170%26class%3D1%26limit%3D500&data=04%7C01%7Cosm%40tomtom.com%7Ca2065442e7e14a5f7f7408d9ed886316%7C374f80267b544a3ab87d328fa26ec10d%7C0%7C0%7C637801992953769114%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=wmlkJzpsSzLtPa36I%2B6TXqXJyG%2BPMH%2Brqn4eA2%2B13X0%3D&reserved=0<https://eur02.safelinks.protection.outlook.com/?url=http%3A%2F%2Fosmose.openstreetmap.fr%2Fen%2Fissues%2Fopen%3Fsource%3D10139%26item%3D1170%26class%3D1%26limit%3D500&data=04%7C01%7COSM%40tomtom.com%7C312db3a6e387408918b908d9f1b34499%7C374f80267b544a3ab87d328fa26ec10d%7C0%7C0%7C637806575286727370%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=WpW%2FRKnAcor0GjGzva7stMzbc2dDmH2SuwSfll8sSeU%3D&reserved=0>

--
minh at nguyen.cincinnati.oh.us<mailto:minh at nguyen.cincinnati.oh.us>

_______________________________________________
Talk-us mailing list
Talk-us at openstreetmap.org<mailto:Talk-us at openstreetmap.org>
https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.openstreetmap.org%2Flistinfo%2Ftalk-us&data=04%7C01%7Cosm%40tomtom.com%7Ca2065442e7e14a5f7f7408d9ed886316%7C374f80267b544a3ab87d328fa26ec10d%7C0%7C0%7C637801992953769114%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=BfQWDedsfE4orzbv6PdH3uLA%2B36F2KqD6RaGyJkqt%2FE%3D&reserved=0<https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.openstreetmap.org%2Flistinfo%2Ftalk-us&data=04%7C01%7COSM%40tomtom.com%7C312db3a6e387408918b908d9f1b34499%7C374f80267b544a3ab87d328fa26ec10d%7C0%7C0%7C637806575286727370%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=1fLBw4Td%2BHG3LvoCz51dOd1lbMlVJJVGmzuAVeC1FAM%3D&reserved=0>
_______________________________________________
Talk-us mailing list
Talk-us at openstreetmap.org<mailto:Talk-us at openstreetmap.org>
https://lists.openstreetmap.org/listinfo/talk-us<https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.openstreetmap.org%2Flistinfo%2Ftalk-us&data=04%7C01%7COSM%40tomtom.com%7C312db3a6e387408918b908d9f1b34499%7C374f80267b544a3ab87d328fa26ec10d%7C0%7C0%7C637806575286727370%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=1fLBw4Td%2BHG3LvoCz51dOd1lbMlVJJVGmzuAVeC1FAM%3D&reserved=0>

--
Eric Ladner
_______________________________________________
Talk-us mailing list
Talk-us at openstreetmap.org<mailto:Talk-us at openstreetmap.org>
https://lists.openstreetmap.org/listinfo/talk-us<https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.openstreetmap.org%2Flistinfo%2Ftalk-us&data=04%7C01%7COSM%40tomtom.com%7C312db3a6e387408918b908d9f1b34499%7C374f80267b544a3ab87d328fa26ec10d%7C0%7C0%7C637806575286727370%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=1fLBw4Td%2BHG3LvoCz51dOd1lbMlVJJVGmzuAVeC1FAM%3D&reserved=0>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/talk-us/attachments/20220217/176f2d98/attachment-0001.htm>