[OSM-talk] Contributing to JOSM.

[Maurice le Rutte]

Apart from doing some mapping I'm currently looking whether I could  
contribute to the development of JOSM. As a Java developer this looks like  
a project I could be some help to, even though my track record for home  
made projects isn't that impressive...

After checking out the source I had two Eclipse errors on marktr in  
AutoScaleAction and tr in MainMenu. According to Eclipse these methods  
didn't exist, while the lines above and below calling the same methods are  
allright. I 'fixed' that by changing the names and then reverting the  
action. Seems like some Eclipse issue, but I don't know what exactly.

Running the JUnit tests 100% success. Good! Running the Functional test:  
first run the keystrokes were send to Eclipse, which opened up some wizard  
and then didn't know what to do next. Second run started JOSM, but some  
tests fail.

This may all be due to my environment not set up correctly, but I couldn't  
find this on the Wiki pages, nor could I find a dedicated mailinglist. As  
I'm not sure whether I have a good baseline currently I'm a bit weary to  
continue.

Maurice.

TESTROOT
SelectionTest
test(SelectionTest)
org.openstreetmap.josm.plugins.PluginException: An error occoured in  
plugin UtilsPlugin
	at  
org.openstreetmap.josm.plugins.PluginProxy.mapFrameInitialized(PluginProxy.java:33)
	at org.openstreetmap.josm.Main.setMapFrame(Main.java:141)
	at framework.FunctionalTestCase.setUp(FunctionalTestCase.java:74)
	at junit.extensions.jfcunit.JFCTestCase$1.run(JFCTestCase.java:314)
	at junit.extensions.jfcunit.JFCTestCase$3.run(JFCTestCase.java:478)
	at java.lang.Thread.run(Thread.java:595)
Caused by: java.lang.reflect.InvocationTargetException
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at  
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at  
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:585)
	at  
org.openstreetmap.josm.plugins.PluginProxy.mapFrameInitialized(PluginProxy.java:30)
	... 5 more
Caused by: java.lang.NullPointerException
	at UtilsPlugin.JosmLint.stopPlugin(JosmLint.java:216)
	at UtilsPlugin.UtilsPlugin.mapFrameInitialized(UtilsPlugin.java:67)
	... 10 more

WayTest
test(WayTest)
junit.framework.AssertionFailedError: expected:<1> but was:<0>
	at junit.framework.Assert.fail(Assert.java:47)
	at junit.framework.Assert.failNotEquals(Assert.java:277)
	at junit.framework.Assert.assertEquals(Assert.java:64)
	at junit.framework.Assert.assertEquals(Assert.java:195)
	at junit.framework.Assert.assertEquals(Assert.java:201)
	at WayTest.test(WayTest.java:19)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at  
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at  
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:585)
	at junit.extensions.jfcunit.JFCTestCase$5.run(JFCTestCase.java:580)
	at junit.extensions.jfcunit.JFCTestCase$3.run(JFCTestCase.java:478)
	at java.lang.Thread.run(Thread.java:595)

junit.extensions.jfcunit.JFCTestCase
warning(junit.framework.TestSuite$1)
junit.framework.AssertionFailedError: No tests found in  
junit.extensions.jfcunit.JFCTestCase
	at junit.framework.Assert.fail(Assert.java:47)
	at junit.framework.TestSuite$1.runTest(TestSuite.java:93)
	at junit.framework.TestCase.runBare(TestCase.java:130)
	at junit.framework.TestResult$1.protect(TestResult.java:110)
	at junit.framework.TestResult.runProtected(TestResult.java:128)
	at junit.framework.TestResult.run(TestResult.java:113)
	at junit.framework.TestCase.run(TestCase.java:120)
	at junit.framework.TestSuite.runTest(TestSuite.java:228)
	at junit.framework.TestSuite.run(TestSuite.java:223)
	at  
org.eclipse.jdt.internal.junit.runner.junit3.JUnit3TestReference.run(JUnit3TestReference.java:128)
	at  
org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
	at  
org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:460)
	at  
org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:673)
	at  
org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:386)
	at  
org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:196)

NodeTest
test(NodeTest)
org.openstreetmap.josm.plugins.PluginException: An error occoured in  
plugin UtilsPlugin
	at  
org.openstreetmap.josm.plugins.PluginProxy.mapFrameInitialized(PluginProxy.java:33)
	at org.openstreetmap.josm.Main.setMapFrame(Main.java:141)
	at framework.FunctionalTestCase.setUp(FunctionalTestCase.java:74)
	at junit.extensions.jfcunit.JFCTestCase$1.run(JFCTestCase.java:314)
	at junit.extensions.jfcunit.JFCTestCase$3.run(JFCTestCase.java:478)
	at java.lang.Thread.run(Thread.java:595)
Caused by: java.lang.reflect.InvocationTargetException
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at  
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at  
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:585)
	at  
org.openstreetmap.josm.plugins.PluginProxy.mapFrameInitialized(PluginProxy.java:30)
	... 5 more
Caused by: java.lang.NullPointerException
	at UtilsPlugin.JosmLint.stopPlugin(JosmLint.java:216)
	at UtilsPlugin.UtilsPlugin.mapFrameInitialized(UtilsPlugin.java:67)
	... 10 more

DeleteTest
test(DeleteTest)
junit.framework.AssertionFailedError: expected:<1> but was:<0>
	at junit.framework.Assert.fail(Assert.java:47)
	at junit.framework.Assert.failNotEquals(Assert.java:277)
	at junit.framework.Assert.assertEquals(Assert.java:64)
	at junit.framework.Assert.assertEquals(Assert.java:195)
	at junit.framework.Assert.assertEquals(Assert.java:201)
	at DeleteTest.test(DeleteTest.java:13)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at  
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at  
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:585)
	at junit.extensions.jfcunit.JFCTestCase$5.run(JFCTestCase.java:580)
	at junit.extensions.jfcunit.JFCTestCase$3.run(JFCTestCase.java:478)
	at java.lang.Thread.run(Thread.java:595)