[OSM-talk] osm2pgsql enhancements
jburgess777 at googlemail.com
Sat Mar 10 12:50:17 GMT 2007
On Fri, 2007-03-09 at 10:17 +0000, Artem Pavlenko wrote:
> > 2) My compiler is complaining about an uninitialised variable in bst.c
> > line 92:
> > cc -g -O2 -Wall -I/usr/include/libxml2 -c -o bst.o bst.c
> > bst.c: In function ‘bst_probe’:
> > bst.c:92: warning: ‘dir’ may be used uninitialized in this function
> Jon Burgess might have the answer but I wouldn't worry about this one.
Nothing to worry about. I remember looking at it some months ago and
concluded that the code was OK. The compiler sees a theoretical code
path which leaves the variable undefined, but in practice this is
impossible. The bst code has been around for ages.
If you update to the latest SVN you will see that I have removed the bst
& avl code. It was only used by the duplicate detection logic and this
provides little benefit now that the Tiger data has gone. The code
cleanup also reduces the memory footprint slightly.
More information about the talk