[OSM-talk] JOSM Validator

[Francisco R. Santos]

On 4/30/07, Dermot McNally <dermotm at gmail.com> wrote:
>
> Folks,


Hi Dermot,

I have been changing and fixing some bugs in the validator plugin, and also
adding a new layer to display graphically the errors, but then went on
vacations for several days, I'll look into these questions this weekend.



I've been using the validator for a week or so in "reduced mode".
> Specifically, I had it installed in such a way that the
> preset/property spell check wasn't working - or rather, wasn't finding
> any errors, which seemed a little strange. On getting it going
> initially I had tried enabling "Check also property values from
> presets", but trying to validate caused an exception to be thrown. So
> although "Spell checker" was enabled, no errors were flagged.


The presets check uses the currently loaded presets file. If no presets
available, no check.

Today, I upgraded everything - JOSM and validator.jar. I also followed
> the procedure outlined in Christoph's tutorial for getting going with
> presets. This has brought about (mostly) an improvement. I can now
> switch on the "check presets" option and I now get some warnings under
> the heading "unknown property values". Seems good so far. However:
>
> * I can no longer click the "fix" button. Doing so used to work, but
> now throws an exception. I can post the dump here if useful, or
> failing that I'll send it to the address it proposes.


Yes, a stacktrace would be useful. Please, send it to frsantos at gmail.com.

* It's catching values that seem to me to be valid and established.
> For example, it dislikes highway=tertiary and amenity=theatre. I
> haven't so far worked out where the list of valid values is defined.


As said, the check  uses the presets file for validation. This file contains
the values that a property can have. If this file does not contain tertiary
for highway or theatre for amenity, it is shown as an error. The check
relies on a good presets file, but I think there is no good presets file
yet.

* It's failing to find a deliberately mis-spelled way property
> (hiiway=test). Am I wrong to assume that this should be within the
> scope of the spell checker?


The spellcheck uses the speller words created by JLS (
http://wiki.openstreetmap.org/index.php/User:JLS/speller). If that word is
not in the list, it is not detected as an error. Currently, it uses the
4-19-2007 list, and I think hiiway is not in that list.

I haven't overlooked any documentation on this, BTW, have I?


I don't think so, as there is no documentation :-).

Dermot
>
> PS: After all those complaints, it's only fair to mention that
> validator has been a hugely useful tool for me.


Thanks, I pretend to expand it a little more so that it is yet more usefull.
Quico
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/talk/attachments/20070503/c3038d3a/attachment.html>