[OSM-talk] JOSM user interface

Robin Rattay rotora at gmx.net
Wed Oct 10 13:33:22 BST 2007


Hi,

On Wed, 10 Oct 2007 11:02:43 +0100, David Earl wrote:
> On 10/10/2007 10:14, Frederik Ramm wrote:
>>> I just compared the two and it is exactly that. In Windows (or Windows
>>> Classic) mode it selects the whole of the item after typing, so
>>> replaces it on typing another character; whereas the Metal on only
>>> selects the remaining characters.
>> 
>> Should we then, instead of making the auto-complete a user preference,
>> automatically disable it when the "windows" look and feel is selected,
>> and enable it otherwise? Or does that sound too much of a hack?
> 
> That would make it more usable but seems overkill.
> 
> Is the bug really in Windows so unfixable, or is there a subtle JOSM bug
> that only shows up in the Windows style?

I accually fixed this bug in my local JOSM copy several weeks ago as I 
was starting out here at OSM.

>     if (item != null) {
>       // remove all text and insert the completed string super.remove(0,
>       getLength());
>       super.insertString(0, item.toString(), a); // select the completed
>       part
>      JTextComponent editor =
> (JTextComponent)comboBox.getEditor().getEditorComponent();
>      editor.setSelectionStart(offs + str.length());
>      editor.setSelectionEnd(getLength());
>    }

This block is followed by the line:

setSelectedItem(item);

After removing this line it works fine under Windows with the Windows L&F 
for me. I can't test it under Linux.

Robin





More information about the talk mailing list