[OSM-talk] bot proposal: shop values cleanup (low use values only, 1 used 250 times, three over 100 times, many used less)

Warin 61sundowner at gmail.com
Thu May 18 09:05:27 UTC 2023


On 18/5/23 04:48, Mateusz Konieczny via talk wrote:
>
>
>
> May 16, 2023, 19:22 by ajt1047 at gmail.com:
>
>     On 24/04/2023 16:57, Mateusz Konieczny via talk wrote:
>>
>>
>>     Apr 22, 2023, 14:10 by ajt1047 at gmail.com:
>>
>>         More generally, anyone with half a brain consuming OSM shop
>>         data (or actually, _any_ external data from _anywhere_) will
>>         look at the values contained in it***.
>>
>>     And that is exactly what lead to proposing this edits - I was
>>     writing code to handle OSM
>>     data and researched tagging situation. And one of[1] effects was
>>     discovering numerous
>>     cases of tags that seem to be exact duplicates of more standard
>>     ones, and retagging
>>     them seems to clearly improve OSM data as far as I can see
>>
>     Your continued tagfiddling here is making it much harder for local
>     mappers to find problem values in OSM data.
>
>     No-one's going to complain about you changing "shop=shoe" to
>     "shop=shoes" - they clearly have the same meaning, so changing the
>     less common form to the more common form is a net benefit.
>
>     However, your recent changes have gone much further than this,
>     included changing shops with values you don't understand into
>     "shop=yes".
>
> For start: no such changes will be made, if requested I can revert changes
> of shop=fixme to shop=yes if it is disputed.
>
> -----------
>
> But I do not really agree with some claims made here and want to 
> explain why.
>
> For start there is a long list of shop values which meaning I do not 
> understand
> (for example, from start of list of exactly such values:
> shop=grossery, shop=towing, shop=showroom, shop=salon, shop=garage,
> shop=pond, shop=consignment...)
>
> This change was made because it was carrying no real info and was 
> obscure value
> unlikely to be found and handled by mappers.
>
>     As an example, consider
>     https://www.openstreetmap.org/way/353944525 .  It was previously
>     "shop=retail", an unusual and rare tag that would likely flag up
>     the interest of a passing local mapper.  You changed it to
>     "shop=yes", of which there are 180,000 of in OSM.
>
> Except people using JOSM validator*, iD, StreetComplete and other 
> tools with special
> support for shop=yes as feature tag. Note that this tools are more or 
> less proactive
> while shop with unusual values will be spotted solely by manual checks
> (as listing all unusual shop values is far from helpful and requires a 
> long
> filtering to skip undocumented values, aliases, confusing values 
> carrying some info)
>
> *and therefore also Osmose, though I would not recommend this QA tool
>
>     No-one is going to spot that as an "unusual" shop at all.
>
> Thousands/tens of thousands were fixed already, at least 10 000 would be
> definitely not spotted and not fixed if they would be just one of 
> 10237 rare shop values.
>

A render finding an unexpected value could simply handle it as 
'shop=yes' and carry on.


If you want to flag these to mappers?Then contact the relevant mapper 
then failing a contact add a fixme/note. ???


shop=garage .. A shop that sells garages...

https://www.totalspan.com.au/residential/garages/garages-with-workshops/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/talk/attachments/20230518/bdaf3389/attachment-0001.htm>


More information about the talk mailing list