[Tile-serving] Parallelizing more of osm2pgsql

[Andy Allan]

On 15 July 2013 00:13, Kai Krueger <kakrueger at gmail.com> wrote:

> I haven't yet committed this work back into the main repositories, as
> the diff processing likely doesn't work yet with the parallelization and
> I know that the gazeteer backend for nominatim is still broken. However,
> the initial import should hopefully now be stable and produce correct
> results.

I realise I'm in danger of sounding like a broken record here, but it
would be extremely valuable to work on a unit test framework for
osm2pgsql. The lack of confidence in whether refactored code gives the
same output as battle-hardened existing code discourages me (and
presumably other people) from testing the new code. The lack of
certainty presumably also discourages other developers from attempting
refactoring, given that there's no sensible manner to find out if the
output is correct in all the (many) gnarly edge cases.

Trying to verify code correctness by importing different planet files
and applying different sequences of diff updates and then hoping that
whoever is brave enough to do this on a production server with enough
users so that one of them happens to spot a broken multipolygon update
- well, lets say I can think of a better approach.

Unit tests.

Cheers,
Andy