[Tile-serving] Test suits (was: Parallelizing more of osm2pgsql)

[Kai Krueger]

On 07/15/2013 02:20 AM, Paul Norman wrote:
>> From: Andy Allan [mailto:gravitystorm at gmail.com]
>> Sent: Monday, July 15, 2013 1:04 AM
>> Subject: Re: [Tile-serving] Parallelizing more of osm2pgsql
>>
>> On 15 July 2013 00:13, Kai Krueger <kakrueger at gmail.com> wrote:
>>
>> Unit tests.
>>
>> Cheers,
>> Andy
> 
> I'd say it sounds like you're volunteering to write them,

Yes, I'd love to see patches for more and better unit or integration tests!

There are already some integration tests found in
https://github.com/openstreetmap/osm2pgsql/blob/master/tests/regression-test.sh.
that run through the various parameters and compare results between
runs. However, they simply compare results (number of objects imported)
to each other, but not to a normative answer. So these tests help catch
crash errors and bugs that change the number of imported objects.

There are also some limited tests for the flat-nodes functions, but
again they are mostly crash bug tests, as they don't have any normative
values to compare results to.

So it would be great if someone could set up a testing framework where
one can test specific behaviour and verify that the output is as
expected, as indeed that would make development much easier (as well as
increase confidence in using osm2pgsql). Once such a system is in place
I'd be happy to help write test cases to cover more of the functionality.


 except that that
> might take away from osm-carto time. :)

It would be great if you could get the last pieces of osm-carto sorted
that block the deployment of orm, so that we can get Z19 on osm.org... ;-)

> 
> I think everyone wants unit tests.
> 
> I guess the first question is, how do we unit test osm2pgsql?

I don't really know the pros and cons of all of the various fancy
testing frameworks. That is one of the reasons I haven't started with a
proper test suit in osm2pgsql yet. So any discussion about this would be
great.


Kai
> 
> 
> _______________________________________________
> Tile-serving mailing list
> Tile-serving at openstreetmap.org
> http://lists.openstreetmap.org/listinfo/tile-serving
>