[Tile-serving] [osm2pgsql] fix some compiler warnings (#91)

[Ondřej Hošek]

This pull request contains fixes to multiple warnings emitted by Clang when osm2pgsql is compiled with `-Wall`. Two of these cases (assignment instead of comparison, fixed in f1efada; and using `strtol` without including stdlib.h, fixed in 292dc6a) lead (or might lead) to errors in program logic; the others are mostly code hygiene.
You can merge this Pull Request by running:

  git pull https://github.com/RavuAlHemio/osm2pgsql unwarn

Or you can view, comment on it, or merge it online at:

  https://github.com/openstreetmap/osm2pgsql/pull/91

-- Commit Summary --

  * Remove unused variables.
  * Comment out unused functions.
  * Declare tagtransform_shutdown in tagtransform.h.
  * Add necessary includes in tagtransform.c.
  * Avoid dangling else by adding braces.
  * Replace erroneous assignment with comparison.

-- File Changes --

    M middle-pgsql.c (2)
    M middle-ram.c (1)
    M node-persistent-cache.c (2)
    M osm2pgsql.c (1)
    M output-gazetteer.c (7)
    M output-pgsql.c (10)
    M parse-pbf.c (2)
    M tagtransform.c (2)
    M tagtransform.h (1)

-- Patch Links --

https://github.com/openstreetmap/osm2pgsql/pull/91.patch
https://github.com/openstreetmap/osm2pgsql/pull/91.diff
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/tile-serving/attachments/20131002/300cb743/attachment.html>