[Tile-serving] [osm2pgsql] Fix memory errors (#175)

alex85k notifications at github.com
Tue Aug 12 10:57:13 UTC 2014


After https://github.com/openstreetmap/osm2pgsql/commit/d1b6c5e563e8eb9d836d97fad094f0a1b35f92ea#diff-a4a10b448709d2cc5dc0c85fb36a2b1c
the RAM cache size can be zero, but ``ram_cache_nodes_set_sparse`` function often accesses ``sparseBlock[0]``. It gives serious memory access errors and failures during testing (detected with Intel Inspector XE when fixing Windows builds https://github.com/openstreetmap/osm2pgsql/issues/17 ).

I am not sure the proposed fix is the best solution, but something should be done with this error.
You can merge this Pull Request by running:

  git pull https://github.com/alex85k/osm2pgsql patch-1

Or you can view, comment on it, or merge it online at:

  https://github.com/openstreetmap/osm2pgsql/pull/175

-- Commit Summary --

  * Fix memory errors

-- File Changes --

    M node-ram-cache.c (2)

-- Patch Links --

https://github.com/openstreetmap/osm2pgsql/pull/175.patch
https://github.com/openstreetmap/osm2pgsql/pull/175.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/osm2pgsql/pull/175
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/tile-serving/attachments/20140812/437bf4f1/attachment-0001.html>


More information about the Tile-serving mailing list