[Tile-serving] [mod_tile] Added couchbase combined storage (#63)

[apmon]

Thanks for your contribution! I haven't looked at your patches in full detail yet, but overall it looks good. A few minor comments I have so far.

If I see it correctly, you added a dependency on the OpenSSL libs. Is it possible to hide all of that behind a #ifdef HAVE_OPENSSL to make sure mod_tile/renderd compile even if the OpenSSL dev files are not installed on the machine. It looks like in meta2tile you also have the memcached.h unconditionally included, which will break compiles if memcached isn't installed.

Is the struct metahash_layout something generic, or specific to this backend? Would it be better off not in the generic metatile.h? Particularly given it introduces that dependency on openssl.

I'll try and have a closer look at the code and give more specific feedback and hopefully we can merge it then at some point

---
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/mod_tile/pull/63#issuecomment-34899389
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/tile-serving/attachments/20140212/5644de89/attachment.html>