[Tile-serving] [osm2pgsql] outtags redeclearation in output_multi_t::process_relation (#336)

[Paul Norman]

>From https://github.com/openstreetmap/osm2pgsql/pull/273#issuecomment-93937271
> In output_multi::process_relation() `outtags` is redeclared [here](https://github.com/openstreetmap/osm2pgsql/blob/master/output-multi.cpp#L366), that can't be right. The tags are probably meant to be filtered again.

I can see two meaningful behaviors here

1. Reset outtags (if not overwritten by m_tagtransform->filter_rel_member_tags). 
2. Use the transformed tags from before, and toss the later generated outtags

I haven't written a lua transform that does fancy relations processing, multi-backend or otherwise, so the desired behavior is entirely unclear to me. Additionally, this function has six TODO comments

cc @kevinkreiser, who wrote the code.

Reading @systemed's [docs/lua.md](https://github.com/openstreetmap/osm2pgsql/blob/master/docs/lua.md#how-to) it seems that an object can end up in tables based on *either* `filter_basic_tags_rel` or `filter_tags_relation_member`. This would imply that we need to do something with outtags from *both* `m_tagtransform->filter_rel_tags` and `m_tagtransform->filter_rel_member_tags`.

---
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/osm2pgsql/issues/336
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/tile-serving/attachments/20150419/6fb518a2/attachment.html>