[Tile-serving] [osm2pgsql] Static analysis 2 (#342)

[Paul Norman]

Does not change what's under discussion for https://github.com/openstreetmap/osm2pgsql/pull/299#discussion_r25123742

Unresolved is https://github.com/openstreetmap/osm2pgsql/pull/299#discussion_r25123613
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/osm2pgsql/pull/342

-- Commit Summary --

  * Fix valid-in-python2 but invalid-in-python3 try-except syntax
  * Include required iostream for std::cerr; was missing and causing test fails
  * Space before print formatters required otherwise this is parsed as C++11 literal
  * ';' outside function is C++11 extension
  * Modernize geometry builder: std::sort instead of ::qsort, rip out manual memory management, catch by const ref
  * Globally: catch by const ref
  * Merge commit '4a5fc188e70a24c9772765c5acbb324e18b07be0' into static_analysis_2

-- File Changes --

    M geometry-builder.cpp (38)
    M middle-pgsql.cpp (2)
    M osm2pgsql.cpp (2)
    M output-pgsql.cpp (4)
    M tests/regression-test.py (22)
    M tests/test-expire-tiles.cpp (2)
    M tests/test-parse-options.cpp (6)
    M tests/test-pgsql-escape.cpp (1)

-- Patch Links --

https://github.com/openstreetmap/osm2pgsql/pull/342.patch
https://github.com/openstreetmap/osm2pgsql/pull/342.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/osm2pgsql/pull/342
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/tile-serving/attachments/20150422/f55527a0/attachment.html>