[Tile-serving] [osm2pgsql] Refactor table_t constructor (#438)

[Paul Norman]

> @@ -19,9 +20,14 @@ typedef std::vector<std::pair<std::string, std::string> > columns_t;
>  class table_t
>  {
>      public:
> -        table_t(const std::string& conninfo, const std::string& name, const std::string& type, const columns_t& columns, const hstores_t& hstore_columns, const int srid,
> -                const bool append, const bool slim, const bool droptemp, const int hstore_mode, const bool enable_hstore_index,
> -                const boost::optional<std::string>& table_space, const boost::optional<std::string>& table_space_index);
> +        /**
> +         * Sets up a new table, creating it if in --create.
> +         * It takes in both options and table_options because in the multi
> +         * backend there can be differences
> +         */
> +        table_t(const std::string& conninfo, const std::string& name,
> +                const std::string& type, const columns_t& columns,
> +                const table_options_t& table_options, const options_t& options);

is this a sensible order for the constructor arguments?

---
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/osm2pgsql/pull/438/files#r36713173
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/tile-serving/attachments/20150810/ed14bbe7/attachment.html>