[Tile-serving] [osm2pgsql] Cleanup based on the output of LLVM's static analyzer (#299)

[Daniel J. H.]

Mainly memory issues, heap corruptions.
But also non-standard VLA usages, ::qsort vs std::sort and minor issues.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/osm2pgsql/pull/299

-- Commit Summary --

  * Fix valid-in-python2 but invalid-in-python3 try-except syntax
  * Include required iostream for std::cerr; was missing and causing test fails
  * Space before print formatters required otherwise this is parsed as C++11 literal
  * ';' outside function is C++11 extension
  * Modernize geometry builder: std::sort instead of ::qsort, rip out manual memory management, catch by const ref
  * Globally: catch by const ref
  * Incrementally rip out manually managed memory
  * No VLAs in C++ (variable length array extension)

-- File Changes --

    M geometry-builder.cpp (38)
    M middle-pgsql.cpp (6)
    M osm2pgsql.cpp (2)
    M output-gazetteer.cpp (37)
    M output-pgsql.cpp (42)
    M parse-o5m.cpp (2)
    M tests/regression-test.py (22)
    M tests/test-expire-tiles.cpp (2)
    M tests/test-parse-options.cpp (6)
    M tests/test-pgsql-escape.cpp (1)

-- Patch Links --

https://github.com/openstreetmap/osm2pgsql/pull/299.patch
https://github.com/openstreetmap/osm2pgsql/pull/299.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/osm2pgsql/pull/299
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/tile-serving/attachments/20150221/bc6a45f5/attachment.html>