[Tile-serving] [osm2pgsql] Cleanup based on the output of LLVM's static analyzer (#299)

Sarah Hoffmann notifications at github.com
Sat Feb 21 17:13:15 UTC 2015


>  } // anonymous namespace
>  
>  void middle_pgsql_t::stop(void)
>  {
>      int i;
>  #ifdef HAVE_PTHREAD
> -    pthread_t threads[num_tables];
> +    std::vector<pthread_t> threads(num_tables);

I don't think there is much to gain here from using a std::vector, as the array is completely static and just local anyways. Doesn't hurt much either, so feel free to ignore me. Dito below.

---
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/osm2pgsql/pull/299/files#r25123666
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/tile-serving/attachments/20150221/61080090/attachment.html>


More information about the Tile-serving mailing list