[Tile-serving] [osm2pgsql] Replace manually allocated strings in middle-pgsql with std::string (#248)

[Paul Norman]

On the existing branch I hit this error - makes it hard to compare
```
Using 8 helper-processes
*** glibc detected *** osm2pgsql/osm2pgsql: double free or corruption (out): 0x00007fed580032e0 ***
======= Backtrace: =========
/lib/x86_64-linux-gnu/libc.so.6(+0x7eb96)[0x7fee7ace2b96]
osm2pgsql/osm2pgsql[0x427cd2]
osm2pgsql/osm2pgsql[0x4272f2]
osm2pgsql/osm2pgsql[0x427414]
osm2pgsql/osm2pgsql[0x427636]
osm2pgsql/osm2pgsql[0x42778a]
osm2pgsql/osm2pgsql[0x421f94]
osm2pgsql/osm2pgsql[0x4200a6]
osm2pgsql/osm2pgsql[0x452f6b]
osm2pgsql/osm2pgsql[0x4534ba]
osm2pgsql/osm2pgsql[0x42f2ae]
/usr/lib/x86_64-linux-gnu/libboost_thread.so.1.55.0(+0xbdaa)[0x7fee7ba5edaa]
/lib/x86_64-linux-gnu/libpthread.so.0(+0x7e9a)[0x7fee7b02be9a]
/lib/x86_64-linux-gnu/libc.so.6(clone+0x6d)[0x7fee7ad583fd]
======= Memory map: ========
```

I'm trying with 1 process for the update, but I wonder if the results will be valid

---
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/osm2pgsql/pull/248#issuecomment-69515457
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/tile-serving/attachments/20150111/bbe36043/attachment.html>