[Tile-serving] [osm2pgsql] Fix warnings when compiling tests, use -Werror with travis (#395)

Jochen Topf notifications at github.com
Thu Jul 16 07:34:09 UTC 2015


> @@ -129,7 +129,7 @@ const std::string &tempdb::conninfo() const {
>      return m_conninfo;
>  }
>  
> -void tempdb::setup_extension(conn_ptr db, const std::string &extension, ...) {
> +void tempdb::setup_extension(conn_ptr db, const std::string extension, ...) {

The whole function should be refactored, probably taking a `std::vector<std::string>&` as argument instead of the variable argument list. This would make the code much cleaner and you don't have problems with references vs. values.

---
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/osm2pgsql/pull/395/files#r34762168
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/tile-serving/attachments/20150716/1cde987d/attachment-0001.html>


More information about the Tile-serving mailing list