[Tile-serving] [osm2pgsql] Fix warnings when compiling tests, use -Werror with travis (#395)

[Paul Norman]

>      // Sparse cache depends on ordered nodes, reject out-of-order ids.
>      // Also check that there is still space.
>      if ((maxSparseId && id < maxSparseId)
>          || (sizeSparseTuples > maxSparseTuples)
>          || ( cacheUsed > cacheSize)) {
> -        if ((allocStrategy & ALLOC_LOSSY) > 0)
> -            return 1;
> -        else {
> +        if (!((allocStrategy & ALLOC_LOSSY) > 0)) {

I think I broke the logic here. Before, if it met one of the out of memory or out of order conditions, it would always exit from this function, either by returning or by util::exit_nicely(). Now, it can go to the later on logic in the right condition

---
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/osm2pgsql/pull/395/files#r34927914
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/tile-serving/attachments/20150717/e8fb9770/attachment.html>