[Tile-serving] [osm2pgsql] Refactor options_t (#418)

[Paul Norman]

* Uses a delegating constructor instead of `options_t::parse`
* Moves DB options into their own class
* Don't try to duplicate libpq logic for port
* Split up the giant parse function
* Default to number of hardware threads
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/osm2pgsql/pull/418

-- Commit Summary --

  * Move parse into a constructor
  * Move db options into database_options_t
  * Rely on libpq for defaults
  * Move options checks into their own function
  * Default the number of processes to the hardware concurrency

-- File Changes --

    M middle-pgsql.cpp (2)
    M options.cpp (233)
    M options.hpp (34)
    M osm2pgsql.cpp (4)
    M output-gazetteer.cpp (4)
    M output-multi.cpp (2)
    M output-pgsql.cpp (2)
    M tests/common-pg.cpp (19)
    M tests/common-pg.hpp (8)
    M tests/test-hstore-match-only.cpp (4)
    M tests/test-middle-flat.cpp (2)
    M tests/test-middle-pgsql.cpp (2)
    M tests/test-output-multi-line-storage.cpp (4)
    M tests/test-output-multi-line.cpp (4)
    M tests/test-output-multi-point-multi-table.cpp (4)
    M tests/test-output-multi-point.cpp (4)
    M tests/test-output-multi-poly-trivial.cpp (10)
    M tests/test-output-multi-polygon.cpp (4)
    M tests/test-output-multi-tags.cpp (4)
    M tests/test-output-pgsql-tablespace.cpp (6)
    M tests/test-output-pgsql-z_order.cpp (6)
    M tests/test-output-pgsql.cpp (30)
    M tests/test-parse-options.cpp (26)

-- Patch Links --

https://github.com/openstreetmap/osm2pgsql/pull/418.patch
https://github.com/openstreetmap/osm2pgsql/pull/418.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/osm2pgsql/pull/418
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/tile-serving/attachments/20150726/3ddf0c0a/attachment.html>