[Tile-serving] [osm2pgsql] change directory for tests if TEST_DATA_DIR is present (#496)

Sarah Hoffmann notifications at github.com
Sat Nov 7 14:37:37 UTC 2015


I don't think changing the working directory is a good idea in general because it might have unintended side effects, for example, when temporary files are created. So I would prefer to hand in the test directory during compile time and use absolute paths for all files inside the tests.

The other thing this PR (and also #497) shows is that the tests urgently need a test framework. This may be as little as a home-grown base test class all the tests inherit from or it may be an external test library. The gist is that a change like this should certainly not have to touch every single source file in tests/.

---
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/osm2pgsql/pull/496#issuecomment-154711196
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/tile-serving/attachments/20151107/37870b5b/attachment.html>


More information about the Tile-serving mailing list