[Tile-serving] [osm2pgsql] Ignore nodes with invalid coordinates. (#455)
Matt Amos
notifications at github.com
Fri Oct 9 16:43:07 UTC 2015
@lonvia, sorry, I didn't explain that very well... I meant it's _conceptually_ the same as having a whole-world bounding box. The libosmium code already checks for an invalid location on each call to `lat()` and `lon()`, and it's exactly that check throwing an exception which was causing osm2pgsql to fail for me.
In 382c5f3 I've bypassed the check on `lat()` and `lon()`, as the code already explicitly checks `valid()`, and this saves us one check (although the check is almost free). However, I'm not as confident that current planets or extracts aren't buggy and, in my opinion, it's better to be defensive and keep the checks.
Possibly it ought to have a warning; "Oops, this input is buggy, you might not get the results you expect.", though? What do you think?
---
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/osm2pgsql/pull/455#issuecomment-146926251
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/tile-serving/attachments/20151009/b6bcf400/attachment.html>
More information about the Tile-serving
mailing list