[Tile-serving] [osm2pgsql] Clean up after flat nodes tests (#458)

Matt Amos notifications at github.com
Sun Oct 11 00:43:16 UTC 2015


The flat nodes tests each create 20GB flat nodes files and didn't remove them when the tests were finished, which would fail on my system which has "only" 35GB free disk space. This PR adds an RAII cleanup object to remove the files when the tests are complete, reducing the amount of disk space needed to "only" 20GB if the tests are run serially.

You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/osm2pgsql/pull/458

-- Commit Summary --

  * Clean up flat nodes files after test to reclaim disk space.
  * Better implementation using RAII to ensure that the file is removed even under exception conditions.

-- File Changes --

    M Makefile.am (4)
    A tests/common-cleanup.cpp (21)
    A tests/common-cleanup.hpp (21)
    M tests/test-middle-flat.cpp (10)
    M tests/test-output-pgsql.cpp (9)

-- Patch Links --

https://github.com/openstreetmap/osm2pgsql/pull/458.patch
https://github.com/openstreetmap/osm2pgsql/pull/458.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/osm2pgsql/pull/458
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/tile-serving/attachments/20151010/a7c71d50/attachment.html>


More information about the Tile-serving mailing list