[Tile-serving] [openstreetmap/osm2pgsql] Don't let invalid geometries into the database (#655)

Sarah Hoffmann notifications at github.com
Wed Nov 30 21:54:25 UTC 2016


lonvia commented on this pull request.



> @@ -209,11 +209,14 @@ geom_ptr geometry_builder::create_simple_poly(GeometryFactory &gf,
     std::unique_ptr<std::vector<Geometry *> > empty(new std::vector<Geometry *>);
     geom_ptr geom(gf.createPolygon(shell.release(), empty.release()));
 
-    if (!geom->isValid()) {
+    if (geom->isEmpty() || !geom->isValid()) {

Good point. @pnorman can we create a test case for that, too?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/osm2pgsql/pull/655
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/tile-serving/attachments/20161130/efc4101e/attachment.html>


More information about the Tile-serving mailing list