[Tile-serving] [openstreetmap/osm2pgsql] Fails to build with GEOS 3.6.0 (#634)

[Bas Couwenberg]

GEOS 3.6.0 has been released, but unfortunately osm2pgsql fails to build with it:
```
/usr/bin/c++   -DBOOST_TEST_DYN_LINK -DFIXED_POINT -DOSM2PGSQL_DATADIR=\"/usr/share/osm2pgsql\" -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -I/build/osm2pgsql-0.90.1+ds -I/build/osm2pgsql-0.90.1+ds/obj-x86_64-linux-gnu -isystem /build/osm2pgsql-0.90.1+ds/contrib/libosmium -I/usr/include/lua5.2 -I/usr/include/postgresql  -g -O2 -fdebug-prefix-map=/build/osm2pgsql-0.90.1+ds=. -fPIE -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2    -Wall -std=c++11 -o CMakeFiles/osm2pgsql_lib.dir/geometry-builder.cpp.o -c /build/osm2pgsql-0.90.1+ds/geometry-builder.cpp
/build/osm2pgsql-0.90.1+ds/geometry-builder.cpp: In member function 'geometry_builder::pg_geom_t geometry_builder::get_wkb_simple(const nodelist_t&, int) const':
/build/osm2pgsql-0.90.1+ds/geometry-builder.cpp:230:25: error: 'geos::geom::GeometryFactory::GeometryFactory()' is protected within this context
         GeometryFactory gf;
                         ^~
In file included from /build/osm2pgsql-0.90.1+ds/geometry-builder.cpp:39:0:
/usr/include/geos/geom/GeometryFactory.h:420:2: note: declared protected here
  GeometryFactory();
  ^~~~~~~~~~~~~~~
/build/osm2pgsql-0.90.1+ds/geometry-builder.cpp:230:25: error: 'virtual geos::geom::GeometryFactory::~GeometryFactory()' is protected within this context
         GeometryFactory gf;
                         ^~
In file included from /build/osm2pgsql-0.90.1+ds/geometry-builder.cpp:39:0:
/usr/include/geos/geom/GeometryFactory.h:474:10: note: declared protected here
  virtual ~GeometryFactory();
          ^
/build/osm2pgsql-0.90.1+ds/geometry-builder.cpp: In member function 'geometry_builder::pg_geoms_t geometry_builder::get_wkb_split(const nodelist_t&, int, double) const':
/build/osm2pgsql-0.90.1+ds/geometry-builder.cpp:266:25: error: 'geos::geom::GeometryFactory::GeometryFactory()' is protected within this context
         GeometryFactory gf;
                         ^~
In file included from /build/osm2pgsql-0.90.1+ds/geometry-builder.cpp:39:0:
/usr/include/geos/geom/GeometryFactory.h:420:2: note: declared protected here
  GeometryFactory();
  ^~~~~~~~~~~~~~~
/build/osm2pgsql-0.90.1+ds/geometry-builder.cpp:266:25: error: 'virtual geos::geom::GeometryFactory::~GeometryFactory()' is protected within this context
         GeometryFactory gf;
                         ^~
In file included from /build/osm2pgsql-0.90.1+ds/geometry-builder.cpp:39:0:
/usr/include/geos/geom/GeometryFactory.h:474:10: note: declared protected here
  virtual ~GeometryFactory();
          ^
/build/osm2pgsql-0.90.1+ds/geometry-builder.cpp: In static member function 'static int geometry_builder::parse_wkb(const char*, multinodelist_t&, bool*)':
/build/osm2pgsql-0.90.1+ds/geometry-builder.cpp:343:21: error: 'geos::geom::GeometryFactory::GeometryFactory()' is protected within this context
     GeometryFactory gf;
                     ^~
In file included from /build/osm2pgsql-0.90.1+ds/geometry-builder.cpp:39:0:
/usr/include/geos/geom/GeometryFactory.h:420:2: note: declared protected here
  GeometryFactory();
  ^~~~~~~~~~~~~~~
/build/osm2pgsql-0.90.1+ds/geometry-builder.cpp:343:21: error: 'virtual geos::geom::GeometryFactory::~GeometryFactory()' is protected within this context
     GeometryFactory gf;
                     ^~
In file included from /build/osm2pgsql-0.90.1+ds/geometry-builder.cpp:39:0:
/usr/include/geos/geom/GeometryFactory.h:474:10: note: declared protected here
  virtual ~GeometryFactory();
          ^
/build/osm2pgsql-0.90.1+ds/geometry-builder.cpp: In member function 'geometry_builder::pg_geoms_t geometry_builder::build_polygons(const multinodelist_t&, bool, osmid_t) const':
/build/osm2pgsql-0.90.1+ds/geometry-builder.cpp:398:25: error: 'geos::geom::GeometryFactory::GeometryFactory()' is protected within this context
         GeometryFactory gf;
                         ^~
In file included from /build/osm2pgsql-0.90.1+ds/geometry-builder.cpp:39:0:
/usr/include/geos/geom/GeometryFactory.h:420:2: note: declared protected here
  GeometryFactory();
  ^~~~~~~~~~~~~~~
/build/osm2pgsql-0.90.1+ds/geometry-builder.cpp:398:25: error: 'virtual geos::geom::GeometryFactory::~GeometryFactory()' is protected within this context
         GeometryFactory gf;
                         ^~
In file included from /build/osm2pgsql-0.90.1+ds/geometry-builder.cpp:39:0:
/usr/include/geos/geom/GeometryFactory.h:474:10: note: declared protected here
  virtual ~GeometryFactory();
          ^
/build/osm2pgsql-0.90.1+ds/geometry-builder.cpp: In member function 'geometry_builder::pg_geom_t geometry_builder::build_multilines(const multinodelist_t&, osmid_t) const':
/build/osm2pgsql-0.90.1+ds/geometry-builder.cpp:536:25: error: 'geos::geom::GeometryFactory::GeometryFactory()' is protected within this context
         GeometryFactory gf;
                         ^~
In file included from /build/osm2pgsql-0.90.1+ds/geometry-builder.cpp:39:0:
/usr/include/geos/geom/GeometryFactory.h:420:2: note: declared protected here
  GeometryFactory();
  ^~~~~~~~~~~~~~~
/build/osm2pgsql-0.90.1+ds/geometry-builder.cpp:536:25: error: 'virtual geos::geom::GeometryFactory::~GeometryFactory()' is protected within this context
         GeometryFactory gf;
                         ^~
In file included from /build/osm2pgsql-0.90.1+ds/geometry-builder.cpp:39:0:
/usr/include/geos/geom/GeometryFactory.h:474:10: note: declared protected here
  virtual ~GeometryFactory();
          ^
/build/osm2pgsql-0.90.1+ds/geometry-builder.cpp: In member function 'geometry_builder::pg_geoms_t geometry_builder::build_both(const multinodelist_t&, int, int, double, osmid_t) const':
/build/osm2pgsql-0.90.1+ds/geometry-builder.cpp:560:25: error: 'geos::geom::GeometryFactory::GeometryFactory()' is protected within this context
         GeometryFactory gf;
                         ^~
In file included from /build/osm2pgsql-0.90.1+ds/geometry-builder.cpp:39:0:
/usr/include/geos/geom/GeometryFactory.h:420:2: note: declared protected here
  GeometryFactory();
  ^~~~~~~~~~~~~~~
/build/osm2pgsql-0.90.1+ds/geometry-builder.cpp:560:25: error: 'virtual geos::geom::GeometryFactory::~GeometryFactory()' is protected within this context
         GeometryFactory gf;
                         ^~
In file included from /build/osm2pgsql-0.90.1+ds/geometry-builder.cpp:39:0:
/usr/include/geos/geom/GeometryFactory.h:474:10: note: declared protected here
  virtual ~GeometryFactory();
          ^
```
This change seems to be the culprit.
```
- C++ API changes:
  - Automatic memory management for GeometryFactory objects
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/osm2pgsql/issues/634
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/tile-serving/attachments/20161025/d11dc21a/attachment.html>