[Tile-serving] [openstreetmap/osm2pgsql] JSONB tags support for slim tables. (#738)

[Paul Norman]

pnorman requested changes on this pull request.

This breaks support on 9.2 and 9.3.

The plan in #692 is to use hstore, which has the same size benefits.

> @@ -75,10 +75,11 @@ namespace {
 // Argument should point to beginning of literal, on return points to delimiter */

The comments need updating as this function no longer takes arrays, but takes json.

You also need to handle arbitrary JSON inputs. It's acceptable to exit on json which is not a bunch of string key:value mappings, but you need to handle any json within that.

I'm not sure *what* differences that entails, but one obvious one is escaping. JSON allows more escape sequences than just `\n` and `\t`

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/osm2pgsql/pull/738#pullrequestreview-31715772
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/tile-serving/attachments/20170408/91982d36/attachment-0001.html>