[Tile-serving] [openstreetmap/osm2pgsql] A new option to use JSONb instead hstore (#672)

[Sarah Hoffmann]

"it's an universal standard" is not a good enough reason to include a new feature in a software. Here are some factors that weigh in when considering new features:

 * number of users actually using the new feature
 * grade of improvement over existing features (adding missing functionality, improving usability, etc.)
 * development effort
 * source code maintainability

Adding native JSON support doesn't get a very high rating on any of these factors, I'm afraid. There are already possibilities to use JSON, either through the lua transforms or by querying the hstore columns with hstore_to_json. hstore is reasonably well supported by postgres libraries. So far you haven't shown any examples where your life will be made easier in practise by having JSON support. The implementation of this feature is not trivial, in particular wrt performance. Finally, there is no way we add another 5 command line options. So an implementation needs to leverage the existing hstore switches.

All that said, you are still welcome to submit a PR which adds JSON. It will be much easier to discuss the advantages and disadvantages on a concrete piece of code. But please don't expect the osm2pgsql maintainers to implement it, there are simply too many issues open which are a lot more pressing.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/osm2pgsql/issues/672#issuecomment-274261541
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/tile-serving/attachments/20170121/8f5ed263/attachment.html>